chore: remove apitypings specific go.mod #15899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
Dec 17, 2024
|
@Parkreiner added you for the TS types |
Keeping the deps in sync between this and the primary go.mod is a headache. Share the go.mod so we can reference all the correct types.
Emyrk
force-pushed
the
stevenmasley/one_go_mod
branch
from
a3cf00a to
181f379
Compare
spikecurtis
approved these changes
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the deps in sync between this and the primary go.mod is
a headache. Share the go.mod so we can reference all the correct
types.
It was done originally to keep
gojaout of the primary go.mod, and becausegutswas on Go 1.23. Guts was fixed to be on the same go version ascoder/coder: coder/guts#11Also adds Tailscale generated types (3414366)
Closes coder/internal#255