Skip to content

chore: unconditionally run all make cmds in CI #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022
Merged

chore: unconditionally run all make cmds in CI #1608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/coder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ jobs:
- name: Install node_modules
run: ./scripts/yarn_install.sh

- name: "make fmt"
run: "make --output-sync -j fmt"
- run: "make --output-sync -j -B fmt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this -B does anything, since the fmt target and its dependencies are already marked as phony, so they'll already be rebuilt every time. Shouldn't hurt, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think you're right, but I'd rather just have them all with -B as a convention.


test-go:
name: "test/go"
Expand Down Expand Up @@ -355,7 +354,7 @@ jobs:
js-${{ runner.os }}-

- name: Build site
run: make site/out/index.html
run: make -B site/out/index.html

- name: Build Release
uses: goreleaser/goreleaser-action@v2.9.1
Expand Down Expand Up @@ -488,7 +487,7 @@ jobs:

- name: Build
run: |
make site/out/index.html
make -B site/out/index.html

- run: yarn playwright:install
working-directory: site
Expand Down
1 change: 1 addition & 0 deletions coderd/database/dump.sql
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.