-
Notifications
You must be signed in to change notification settings - Fork 937
feat: Allow regen-ssh and fetching a single user from the cli #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Who all can regenerate a user's ssh key? I assumed it was only the user themselves. |
Admins can do it too on other people. But we can make that a feature of impersonating. I can drop the argument, and just always use |
I think if the API supports it we should mimic that here and still support username. I just wasn't sure what matches the API perms. It also seems useful for admins to be able to do this in batches if they require rotation, etc. |
Should I default to 'me' if there is no argument then? That seems like it could lead to a mistake. |
Intuitively, if I run With regards to |
I brought back the user arg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--
- rename 'userUpdate.go' -> 'userupdate.go' - cmd 'users get' -> 'users show'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only reviewing UX, not code. But LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup this looks great to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments on copy, but LGTM
* feat: Allow regen-ssh and fetching a single user from the cli
Some more CLI user CRUD