Skip to content

fix: using a trailing slash on login url #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2022
Merged

fix: using a trailing slash on login url #1622

merged 1 commit into from
May 20, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented May 20, 2022 

./coder login https://dev.coder.com/

Used to give back: https://dev.coder.com//cli-auth
now: https://dev.coder.com/cli-auth

BrunoQuaresma
BrunoQuaresma approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Emyrk Emyrk merged commit c189fc5 into main May 20, 2022
@Emyrk Emyrk deleted the stevenmasley/handle_double_slash branch May 20, 2022 17:42
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@Emyrk @kylecarbs
fix: using a trailing slash on login url (#1622)
4cf4d64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @BrunoQuaresma