ci!: set pr write perms on release-labels
#16380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
changed the title
release-labelsrelease-labels
ethanndickson
changed the title
release-labelsrelease-labels
ethanndickson
changed the title
release-labelsrelease-labels
ethanndickson
changed the title
release-labelsrelease-labels
ethanndickson
changed the title
release-labelsrelease-labels
ethanndickson
changed the title
release-labelsrelease-labels
ethanndickson
changed the title
release-labelsrelease-labels
ethanndickson
changed the title
release-labelsrelease-labels
ethanndickson
changed the title
release-labelsrelease-labels
ethanndickson
force-pushed
the
ethan/fix-release-labels
branch
from
9da4f05 to
ab8acbe
Compare
matifali
approved these changes
Feb 3, 2025
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Not actually a breaking change, I just forgot to change the title before merging...
I'm pretty sure this is the fix, but I can't test it without merging it, as
pull_request_targetcauses the workflow to run using the workflow onmain(where the permissions aren't set).This comment would seem to indicate that
pull_request_targetwith PR write perms does the trick: actions/labeler#136 (comment)From what I can tell this job has been broken since ~nov '24, which leads me to believe it was the permissions change made that month: https://github.com/coder/coder/actions/runs/11915659159/job/33206435274