Skip to content

Add helper text to unauthorized error messages #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 23, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJain AbhineetJain commented May 23, 2022

Adds a suggestion to login in the error messages for users when receiving unauthorized errors.

Subtasks:

  • Handle authorization errors due to the absence of url/session files
  • Handle authorization errors due to incorrect session key
  • Add unit tests

Fixes #917

@AbhineetJain AbhineetJain requested a review from Emyrk May 23, 2022 16:20
@AbhineetJain AbhineetJain requested a review from Emyrk May 23, 2022 17:59
@AbhineetJain AbhineetJain marked this pull request as ready for review May 23, 2022 18:00
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. LG!

@AbhineetJain AbhineetJain merged commit 4a78bad into main May 23, 2022
@AbhineetJain AbhineetJain deleted the 917-bug-cleaner-error-message branch May 23, 2022 18:51
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* add helper text to unauthorized error messages

* fix lint error, add unit tests

* fix test name

* fix test name

* fix lint errors in test

* add unauthorized test for templates create

* remove unnecessary variable

* remove Error struct, change error message

* change [url] to <url>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: cleaner error message for non logged-in user
2 participants