fix: ensure targets are propagated to inbox #16985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than give targets special treatment, we should put it in the payload like everything else. This correctly propagates notification targets to the inbox table without much code change.
DanielleMaywood
changed the title
DanielleMaywood
requested review from
defelmnq and
mtojek
and removed request for
defelmnq
mtojek
reviewed
Mar 19, 2025
| @@ -74,7 +74,7 @@ func (s *StoreEnqueuer) EnqueueWithData(ctx context.Context, userID, templateID | |||
| dispatchMethod = metadata.CustomMethod.NotificationMethod | |||
| } | |||
|
|
|||
| payload, err := s.buildPayload(metadata, labels, data) | |||
| payload, err := s.buildPayload(metadata, labels, data, targets) | |||
There was a problem hiding this comment.
Is it the first time we're processing targets? Before we merge this one, I'd like to understand the use case. AFAIR targets is an array of UUIDs, and that can be a combination of user UUID, template UUID, workspace UUID. Are we going to discover types of resources?
There was a problem hiding this comment.
I see, I missed the context. Obviously it is too late for this feedback, so ignore the comment 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
targetscolumn ininbox_notificationsdoesn't get filled. This PR fixes that. Rather than give targets special treatment, we should put it in the payload like everything else. This correctly propagates notification targets to the inbox table without much code change.