feat: Add rbac to templateversion+orgmember endpoints #1713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
changed the title
Emyrk
commented
May 25, 2022
Comment on lines
+65
to
+67
| // ExtractOrganizationMemberParam grabs a user membership from the "organization" and "user" URL parameter. | ||
| // This middleware requires the ExtractUser and ExtractOrganization middleware higher in the stack | ||
| func ExtractOrganizationMemberParam(db database.Store) func(http.Handler) http.Handler { |
There was a problem hiding this comment.
Before ExtractOrganization did this with the APIKey.UserID. That didn't make sense to me, as we use {user} for ExtractUser.
So I changed this to use the user from {user} and org from {organization}
Emyrk
requested review from
kylecarbs,
spikecurtis and
johnstcn
and removed request for
kylecarbs
johnstcn
reviewed
May 25, 2022
johnstcn
reviewed
May 25, 2022
johnstcn
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RBAC on
{templateversions}endpoints andassign org rolesendpoint.