chore: deprecate ResourceSystem #17217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
force-pushed
the
spike/resource-system
branch
7 times, most recently
from
398c07d to
7e6e26c
Compare
spikecurtis
changed the title
|
I initially added a ruleguard rule about it, but it's used so widely that the list of exceptions would be unbearably long. Hopefully the deprecation warning in IDEs will ward people off. |
spikecurtis
force-pushed
the
spike/resource-system
branch
from
7e6e26c to
c8b8cf4
Compare
Emyrk
approved these changes
Apr 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
ResourceSystem. It's a large collection of unrelated things, and violates the principle of least privilege because to get access to low-security stuff like various statistics, you also get access to serious-security stuff like crypto keys.We should eventually break it up and remove it, but the least we can do for now is not make the problem worse.