feat: add experimental Chat UI #17650
Conversation
johnstcn
force-pushed
the
cj/rebase/chat-ui
branch
2 times, most recently
from
9cc72d3 to
e7559c3
Compare
johnstcn
force-pushed
the
cj/rebase/chat
branch
2 times, most recently
from
a7d6a2f to
54a20db
Compare
johnstcn
force-pushed
the
cj/rebase/chat-ui
branch
2 times, most recently
from
6a805f9 to
ae9fbc0
Compare
johnstcn
force-pushed
the
cj/rebase/chat-ui
branch
from
ae9fbc0 to
9a3fcc9
Compare
johnstcn
force-pushed
the
cj/rebase/chat-ui
branch
from
9a3fcc9 to
942741e
Compare
| args: unknown; | ||
| result?: unknown; |
There was a problem hiding this comment.
review: changed to unknown to avoid any
| @@ -717,11 +708,12 @@ const FilePreview: FC<{ files: Record<string, string>; prefix?: string }> = | |||
| ); | |||
| }); | |||
|
|
|||
| // TODO: generate these from codersdk/toolsdk.go. | |||
There was a problem hiding this comment.
review: ideally these would be autogenerated, but deferring this for now
| export interface ChatContext { | ||
| selectedModel: string; | ||
| modelConfig: LanguageModelConfig; | ||
|
|
||
| setSelectedModel: (model: string) => void; | ||
| } |
There was a problem hiding this comment.
review: Ideally I'd like to move this into useAgenticChat but ran out of time.
johnstcn
force-pushed
the
cj/rebase/chat-ui
branch
2 times, most recently
from
cb80800 to
e29b101
Compare
There was a problem hiding this comment.
Overall, it is ok and I didn't find anything that could cause major bugs or bad user experiences. However, we are not following some FE agreements we did like using the new shadcn components, TailwindCSS for styles, or Lucide icons.
I also think the design is not the best when dealing with error handling and loading states. We probably could make a better use of design work here to be honest, but I'm not sure how urgent this release is.
There was a problem hiding this comment.
I would move this file to sites/src/modules/chat/useAgenticChat.ts.
There was a problem hiding this comment.
Even though it's imported in modules/dashboard/NavBar/NavbarView?
There was a problem hiding this comment.
Yeap! I think it makes more sense. But no strong thoughts, you can leave as it is if it makes more sense to you.
There was a problem hiding this comment.
I'm going to leave it where it is for now; I think there's more scope to refactor here.
There was a problem hiding this comment.
Not sure if this should be included in the scope of this PR, but all the new pages and components are made using shadcn/ui components, TailwindCSS styles, and Lucide icons as part of our redesign effort.
johnstcn
force-pushed
the
cj/rebase/chat-ui
branch
2 times, most recently
from
5fb99bd to
5f2536f
Compare
Builds on #17570 Frontend portion of https://github.com/coder/coder/tree/chat originally authored by @kylecarbs Additional changes: - Addresses linter complaints - Brings `ChatToolInvocation` argument definitions in line with those defined in `codersdk/toolsdk` - Ensures chat-related features are not shown unless `ExperimentAgenticChat` is enabled. Co-authored-by: Kyle Carberry <kyle@carberry.com>
johnstcn
force-pushed
the
cj/rebase/chat-ui
branch
from
5f2536f to
8b48872
Compare
Builds on #17570
Frontend portion of https://github.com/coder/coder/tree/chat originally authored by @kylecarbs
Additional changes:
ChatToolInvocationargument definitions in line with those defined incodersdk/toolsdkExperimentAgenticChatis enabled.