Skip to content

fix: only override img size for direct button children #18540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

The issue was causing the select menu, that uses an avatar inside of the button, to have a wrong size.

Before:
Screenshot 2025-06-24 at 13 18 51

After:
Screenshot 2025-06-24 at 13 18 41

@BrunoQuaresma BrunoQuaresma self-assigned this Jun 24, 2025
@BrunoQuaresma BrunoQuaresma changed the title fix: only override img size for direct children fix: only override img size for direct button children Jun 24, 2025
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the stories all look good, so 🤷‍♀️

@BrunoQuaresma BrunoQuaresma merged commit cd484db into main Jun 24, 2025
35 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-button-img-size branch June 24, 2025 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants