feat: support dynamic parameters on create template request #18636
+71
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
Jun 27, 2025
codersdk/organizations.go
Outdated
Comment on lines
204
to
208
| // UseClassicParameterFlow allows optionally specifying whether | ||
| // the template should use the classic parameter flow. The default if unset is | ||
| // true, and is why `*bool` is used here. When dynamic parameters becomes | ||
| // the default, this will default to false. | ||
| UseClassicParameterFlow *bool `json:"template_use_classic_parameter_flow"` |
There was a problem hiding this comment.
The inverted logic is a bit annoying. When dynamic parameters becomes the stable and primary method, then the default is false. So this will make sense in 1 to 2 releases.
Emyrk
force-pushed
the
stevenmasley/dynamic_on_first_request
branch
2 times, most recently
from
83e4418 to
9f6daa6
Compare
Emyrk
force-pushed
the
stevenmasley/dynamic_on_first_request
branch
from
9f6daa6 to
7fb96d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future work is to add this checkbox to the UI to opt into dynamic parameters from the first template create.