feat(examples/templates): add docker-devcontainer template and rename envbuilder template
#18741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
commented
Jul 3, 2025
| @@ -1,25 +1,27 @@ | |||
| --- | |||
| display_name: Docker (Devcontainer) | |||
| description: Provision envbuilder containers as Coder workspaces | |||
| display_name: Docker-in-Docker Dev Containers | |||
There was a problem hiding this comment.
Open to naming suggestions.
mtojek
approved these changes
Jul 3, 2025
johnstcn
approved these changes
Jul 3, 2025
mafredri
force-pushed
the
mafredri/feat-example-devcontainer-template
branch
from
6689bbd to
b9a3b72
Compare
DanielleMaywood
approved these changes
Jul 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new
docker-devcontainertemplate which allows you to provision a workspace running in Docker, that also creates workspaces via Docker running inside (DinD).docker-devcontainertodocker-envbuilderdocker-devcontainerexample templateSince GitHub is not detecting the renames properly and creating a hard-to-parse diff, I suggest reviewing commit-by-commit.