Skip to content

fix: Properly remove non matched workspaces #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2022
Merged

fix: Properly remove non matched workspaces #2649

merged 1 commit into from
Jun 25, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 25, 2022

Previously was not filtering workspaces from the result. Meaning existing workspaces would not be removed if you inputted a search query that returns a smaller set.

The 5s refresh or refreshing page was a required workaround before this

@Emyrk Emyrk requested a review from a team as a code owner June 25, 2022 00:16
AbhineetJain
AbhineetJain approved these changes Jun 25, 2022
View reviewed changes
Copy link
Contributor

@AbhineetJain AbhineetJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! 🙌

@Emyrk Emyrk requested a review from AbhineetJain June 25, 2022 21:17
@Emyrk Emyrk merged commit 4779621 into main Jun 25, 2022
@Emyrk Emyrk deleted the stevenmasley/workspaces_empty_resp branch June 25, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@AbhineetJain AbhineetJain Awaiting requested review from AbhineetJain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Emyrk @kylecarbs @AbhineetJain