Skip to content

agent: Don't set GIT_* environment variables #2980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dwahler
Copy link
Contributor

@dwahler dwahler commented Jul 13, 2022

These variables take precedence over settings in the user's .gitconfig, which leads to surprising behavior, as described in #2665.

These variables take precedence over settings in the user's .gitconfig, which leads to surprising behavior.
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clean these up from being sent in the metadata too if they aren't being used anymore.

@dwahler
Copy link
Contributor Author

dwahler commented Jul 19, 2022

This change was incorporated into #3034.

@dwahler dwahler closed this Jul 19, 2022
@github-actions github-actions bot deleted the dwahler/2665-remove-git-env-vars branch February 4, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants