Skip to content

docs: add comment to ResourceAvatar #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2022
Merged

docs: add comment to ResourceAvatar #3822

merged 1 commit into from
Sep 2, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 1, 2022

I originally asked @BrunoQuaresma on Slack why we weren't using these same strings for workspace resource types on the backend. Turns out it's based on Terraform and these are only the most used ones. We agreed this context should live next to the code so this adds that.

@jsjoeio jsjoeio requested a review from a team as a code owner September 1, 2022 23:44
@jsjoeio jsjoeio requested review from presleyp and removed request for a team September 1, 2022 23:44
@jsjoeio jsjoeio self-assigned this Sep 1, 2022
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jsjoeio jsjoeio merged commit 3c91b92 into main Sep 2, 2022
@jsjoeio jsjoeio deleted the jsjoeio/add-comment branch September 2, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants