Make color usage more consistent #3842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks more clickable than lightening the background
Same up as down. Contrast text everywhere except nav, where it matches links and avatar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3572
Putting up a draft so I can check Chromatic as I go.
- Made up/down/right arrows match nearby textpalette.action.hoverfor use whenever a background gets highlighted on hover (happens in the nav, user dropdown, and clickable table rows, so now they match). This color matches the table border, which I think looks nice, but I'm also open to changing it. The real win is the consistency.I previously denied two Chromatic changes to remind myself to make the arrows look disabled - that should be fixed now.