Skip to content

Make color usage more consistent #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 6, 2022
Merged

Make color usage more consistent #3842

merged 17 commits into from
Sep 6, 2022

Conversation

presleyp
Copy link
Contributor

@presleyp presleyp commented Sep 2, 2022

Closes #3572

Putting up a draft so I can check Chromatic as I go.

  • Use the same color for Avatar and inactive NavBar links.
  • Change contained button hover - it was changing the background to black which was not noticeable and not in our color theme. Now the border lightens instead:

Screen Shot 2022-09-02 at 4 15 34 PM

- Made up/down/right arrows match nearby text

Screen Shot 2022-09-02 at 4 45 58 PM

  • Deleted unused components SplitButton and DialogSearch.
  • Added palette.action.hover for use whenever a background gets highlighted on hover (happens in the nav, user dropdown, and clickable table rows, so now they match). This color matches the table border, which I think looks nice, but I'm also open to changing it. The real win is the consistency.

Screen Shot 2022-09-02 at 4 16 20 PM

  • Made box-shadows consistent (excepting the insets and one whose component I think we should delete)

I previously denied two Chromatic changes to remind myself to make the arrows look disabled - that should be fixed now.

@presleyp presleyp requested a review from a team as a code owner September 2, 2022 16:42
@presleyp presleyp requested review from jsjoeio and removed request for a team September 2, 2022 16:42
@presleyp presleyp marked this pull request as draft September 2, 2022 16:43
@presleyp presleyp removed the request for review from jsjoeio September 2, 2022 16:43
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@presleyp presleyp merged commit 1f55135 into main Sep 6, 2022
@presleyp presleyp deleted the presleyp/3572 branch September 6, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make light grey colors consistent
2 participants