fix: Setup redirect #4064
Merged
fix: Setup redirect #4064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
requested review from
code-asher
and removed request for
a team
bpmct
approved these changes
Sep 14, 2022
code-asher
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Looks good! Verified it works on my deployment.
Out of curiosity it looks like the auth xservice is maybe supposed to do a redirect? Not sure if that means the service is broken or if these lines are actually doing something else or these lines should be removed:
coder/site/src/xServices/auth/authXService.ts
Lines 410 to 411 in ec453f0
|
@code-asher good point. I will take a look into that. Since our "guards redirects" are made using Routes, I'm removing this and updating the LoginPage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4050