Skip to content

fix: ignore context canceled error on server #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 20, 2022
Merged

fix: ignore context canceled error on server #4128

merged 4 commits into from
Sep 20, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Sep 20, 2022

Doesn't really make sense to show an error when gracefully shutting down the server.

image

@coadler coadler requested a review from kylecarbs September 20, 2022 03:44
@coadler coadler self-assigned this Sep 20, 2022
@coadler coadler merged commit 8d7954b into main Sep 20, 2022
@coadler coadler deleted the colin/ignore-canceled branch September 20, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @kylecarbs