Skip to content

experiment: Switch to BuildJet Linux Runners #4846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2022
Merged

experiment: Switch to BuildJet Linux Runners #4846

merged 3 commits into from
Nov 1, 2022

Conversation

kylecarbs
Copy link
Member

No description provided.

@kylecarbs kylecarbs self-assigned this Nov 1, 2022
@kylecarbs kylecarbs force-pushed the buildjet branch 2 times, most recently from 4d21789 to bd7f7e5 Compare November 1, 2022 20:09
@kylecarbs kylecarbs marked this pull request as ready for review November 1, 2022 20:20
@@ -276,7 +276,7 @@ jobs:

test-go:
name: "test/go"
runs-on: ${{ matrix.os }}
runs-on: ${{ matrix.os == 'ubuntu-latest' && 'buildjet-16vcpu-ubuntu-2204' || matrix.os }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you just change the os in the matrix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good question

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it's a required check so i'd rather leave it so we don't pollute job names

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh reasonable

@kylecarbs kylecarbs merged commit 29dc5f6 into main Nov 1, 2022
@kylecarbs kylecarbs deleted the buildjet branch November 1, 2022 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants