Skip to content

fix: Remove action from build cancelation names #4930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022
Merged

fix: Remove action from build cancelation names #4930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions codersdk/workspacedisplaystatus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ func WorkspaceDisplayStatus(jobStatus ProvisionerJobStatus, transition Workspace
case ProvisionerJobPending:
return "Queued"
case ProvisionerJobCanceling:
return "Canceling action"
return "Canceling"
case ProvisionerJobCanceled:
return "Canceled action"
return "Canceled"
case ProvisionerJobFailed:
return "Failed"
default:
Expand Down
4 changes: 2 additions & 2 deletions codersdk/workspacedisplaystatus_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ func TestWorkspaceDisplayStatus(t *testing.T) {
name: "CancelingStatusWithStartTransition",
jobStatus: ProvisionerJobCanceling,
transition: WorkspaceTransitionStart,
want: "Canceling action",
want: "Canceling",
},
{
name: "CanceledStatusWithStartTransition",
jobStatus: ProvisionerJobCanceled,
transition: WorkspaceTransitionStart,
want: "Canceled action",
want: "Canceled",
},
{
name: "FailedStatusWithDeleteTransition",
Expand Down