Skip to content

Minor CSS adjustments #5193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Minor CSS adjustments #5193

wants to merge 1 commit into from

Conversation

ElliotG
Copy link
Contributor

@ElliotG ElliotG commented Nov 29, 2022

These changes are purely to make the UI a bit cleaner on a smaller screen. See attached screenshots.

These changes are purely to make the UI a bit cleaner on a smaller screen. See attached screenshots.
@ElliotG ElliotG requested a review from a team as a code owner November 29, 2022 17:19
@ElliotG ElliotG requested review from code-asher and removed request for a team November 29, 2022 17:19
@github-actions
Copy link

github-actions bot commented Nov 29, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ElliotG
Copy link
Contributor Author

ElliotG commented Nov 29, 2022

Screen Shot 2022-11-29 at 10 17 10 AM

The screenshot above is showing what it looks like when the window is more squished. It's primarily an issue that the padding takes up a significant amount of screen space, and this proposal is to cut it down. It would look like the screenshot below.

Screen Shot 2022-11-29 at 10 17 06 AM

@ElliotG
Copy link
Contributor Author

ElliotG commented Nov 29, 2022

On widescreen, the change is fairly minimal:

Before:
Screen Shot 2022-11-29 at 10 16 43 AM

After:

Screen Shot 2022-11-29 at 10 16 26 AM

@ElliotG
Copy link
Contributor Author

ElliotG commented Nov 29, 2022

I have read the CLA Document and I hereby sign the CLA

@ElliotG
Copy link
Contributor Author

ElliotG commented Nov 29, 2022

recheck

@BrunoQuaresma
Copy link
Collaborator

Hey, @ElliotG thanks for the fix. I'm going to change the workspace Stats in my next PR to use a "standard" component for that. Is it ok if I apply your changes to it?

@BrunoQuaresma
Copy link
Collaborator

What do you think about this for smaller viewports?
Screen Shot 2022-11-29 at 14 50 22

@ElliotG
Copy link
Contributor Author

ElliotG commented Nov 29, 2022

Works for me.

@ElliotG ElliotG closed this Nov 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants