refactor: Refactor update check banner #5708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #5708 since it moves the service banner to the dashboard layout |
@BrunoQuaresma Does this resolve #5698? If so, could we please cherry-pick just that fix out and deploy separately? I want to make sure I give this cool refactor the attention it deserves and I'm worried that will hold up the resolution for that ticket. |
Kira-Pilot
approved these changes
Jan 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A found video is a good way to explain this refactoring:
reduced-size.mp4
Sorry for the low quality, I had to reduce it to under 100MB.