Skip to content

chore!: Standardize prometheus time metrics to seconds #5709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2023
Merged

chore!: Standardize prometheus time metrics to seconds #5709

merged 3 commits into from
Jan 13, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jan 13, 2023 •
edited
Loading

From this discussion: #5690 (comment)

@Emyrk Emyrk requested a review from coadler January 13, 2023 15:20
@Emyrk Emyrk requested a review from johnstcn January 13, 2023 16:15
@johnstcn johnstcn requested a review from deansheather January 13, 2023 16:36
johnstcn
johnstcn reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favour of this but wary of this potentially breaking users' dashboards.

deansheather
deansheather approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking so the PR should be updated to have a ! after chore (e.g. chore!: Standardize ...)

@Emyrk Emyrk changed the title chore: Standardize prometheus time metrics to seconds chore!: Standardize prometheus time metrics to seconds Jan 13, 2023
@Emyrk
Copy link
Member Author

Emyrk commented Jan 13, 2023

@johnstcn I am aware, but rather do it asap than hold off. I think it is worth it.

@Emyrk Emyrk merged commit f76ef98 into main Jan 13, 2023
@Emyrk Emyrk deleted the stevenmasley/prom_base_metrics branch January 13, 2023 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2023
@mafredri mafredri added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@deansheather deansheather deansheather approved these changes

@coadler coadler Awaiting requested review from coadler

Assignees
No one assigned
Labels
release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Emyrk @johnstcn @deansheather @mafredri