Skip to content

fix: use a waitgroup to ensure all connections are cleaned up in agent #5910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2023
Merged

fix: use a waitgroup to ensure all connections are cleaned up in agent #5910

merged 2 commits into from
Jan 29, 2023

Conversation

kylecarbs
Copy link
Member

There was a race where connections would be created at the same time as close. The net.Conn produced by Tailscale doesn't close then the listener does.

@kylecarbs
fix: use a waitgroup to ensure all connections are cleaned up in agent
5103df2 
There was a race where connections would be created at the same time as close.
The `net.Conn` produced by Tailscale doesn't close then the listener does.
@kylecarbs kylecarbs self-assigned this Jan 29, 2023
@kylecarbs kylecarbs merged commit 0d08065 into main Jan 29, 2023
@kylecarbs kylecarbs deleted the fixconntracking branch January 29, 2023 23:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylecarbs