Skip to content

fix(site): Don't handle 304 as error #6655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

fix(site): Don't handle 304 as error #6655

merged 1 commit into from
Mar 20, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix #6645

@BrunoQuaresma BrunoQuaresma requested review from mtojek and a team March 17, 2023 19:01
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 17, 2023
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team March 17, 2023 19:01
mtojek
mtojek approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@BrunoQuaresma BrunoQuaresma merged commit a4d86e9 into main Mar 20, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-template-settings-submission branch March 20, 2023 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(site): TemplateSettings form fails submition
3 participants
@BrunoQuaresma @mtojek @Kira-Pilot