Skip to content

fix: Validate template version name #6804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2023
Merged

fix: Validate template version name #6804

merged 3 commits into from
Mar 27, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Mar 27, 2023 •
edited
Loading

Fixes: #6781

Changes:

  • fix RBAC: consider that a template may not be assigned
  • validate template version name
  • check if the template version name is unique (template ID, name)

@mtojek mtojek self-assigned this Mar 27, 2023
@mtojek mtojek marked this pull request as ready for review March 27, 2023 11:11
@mtojek mtojek requested a review from BrunoQuaresma March 27, 2023 11:11
@mtojek mtojek changed the title feat: Validate template versio name feat: Validate template version name Mar 27, 2023
@mtojek mtojek changed the title feat: Validate template version name fix: Validate template version name Mar 27, 2023
BrunoQuaresma
BrunoQuaresma approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mtojek mtojek merged commit 8187992 into coder:main Mar 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PATCH /templatesversions/:id is not validating the uniqueness of a name
2 participants
@mtojek @BrunoQuaresma