feat(site): Add template embed page #7501
Conversation
BrunoQuaresma
requested review from
a team,
Kira-Pilot and
rodrimaia
and removed request for
a team
| ) => Omit<RichParameterInputProps, "parameter" | "index"> | ||
| } & Pick<ComponentProps<typeof FormSection>, "classes"> | ||
|
|
||
| export const MultableTemplateParametersSection: FC< |
There was a problem hiding this comment.
mutable instead of multable ( and other places too)
| @@ -24,6 +25,13 @@ export const decorators = [ | |||
| </HistoryRouter> | |||
| ) | |||
| }, | |||
| (Story) => { | |||
There was a problem hiding this comment.
why do we need this now?
There was a problem hiding this comment.
This is how the new Storybook version recommends using it when creating stories. https://storybook.js.org/docs/react/writing-stories/introduction#defining-stories
There was a problem hiding this comment.
Just tried it out and it generates nicely. I noticed the sidebar is independently scrollable, yet (on my 2019 MacBook pro) the embed button also needs to be scrolled a bit to see the full thing. Could you compress it a bit so the right side does not need to scroll on most displays?
Screen.Recording.2023-05-15.at.8.30.49.AM.mov
I also saw that, by default, the options are unselected which is nice so that it will use the template default. However, after you select one there is no way to unselect. Thoughts on a "reset" button, or do you think just refreshing it is fine?
|
This looks great! I was thinking that next time we're adjusting legacy MUI classes, maybe we just port them over to Emotion so that we can eventually rip |
It is because I'm "saying" to CSS to sticky the "button canvas" from the top when it hits 40px. If we stretch the height, the left sidebar, having the form, will also be smaller which for me is not very good since those forms can be quite long. You could easily test that by inspecting the button canvas and removing the option "position: sticky" and adjusting its height.
This is an interesting case and maybe for a different task since we are using this same flow when creating a workspace. We might add when the options are not required, an option called "None of the above" or something similar. |
Preview:
