feat: add cohesive e2e tests for the web terminal, apps, and workspaces #8140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
approved these changes
Jun 21, 2023
kylecarbs
force-pushed
the
supere2e
branch
2 times, most recently
from
0f2d64d to
128dff2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets a solid framework for doing more in the future as well... it's extremely easy to add more tests with complex scenarios. The tests look extremely similar to the Go tests, which should allow backend devs to contribute easily!
They should scale well, too, because creating a workspace doesn't provide infrastructure... it's essentially mocked using the echo provisioner.