fix: fix TestPGCoordinatorDual_Mainline flake #8228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
mtojek
approved these changes
Jun 27, 2023
enterprise/tailnet/pgcoord_test.go
Outdated
| assert.Contains(t, derps, e, "expected DERP %v, got %v", e, derps) | ||
| } | ||
|
|
||
| func contains(s []int, i int) bool { |
There was a problem hiding this comment.
We should remove our slices package maybe if this has all the ones we made.
Signed-off-by: Spike Curtis <spike@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the test flake seen here: https://github.com/coder/coder/actions/runs/5376578815/jobs/9753922291?pr=8195
What was happening is that there was a duplicate update pushed, due to races in the test between connecting the clients, agents, and initial heartbeats. We attempt to suppress duplicates by serializing the updates to JSON, and comparing with the last update, but this is sensitive to ordering of the nodes.
Ultimately, the updates are idempotent, so dupes are benign. I'm not going to get super serious about suppressing duplicates by like, sorting into a canonical order or whatever.
Instead, I've just updated the test code to tolerate getting extra updates on the way to whatever final state it's looking for.