fix: removing prettier path in vscode config #8255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually looking at the PR that added it: #8028 (comment) Maybe there was some issue with the wrong Prettier binary being used? Like if it was globally installed or something? Not sure, we might have to ask @BrunoQuaresma what exactly the problem was. But we should still merge this anyway since it is broken. Maybe we will want to add the line back later if they fix the issue depending on what @BrunoQuaresma says. |
|
@Kira-Pilot you are 100% right |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we set the prettier path in our VS Code config at some point, probably to get around this bug.
The latest version of VS Code contains a fix for this issue, and so we should take this path out, as it actually now breaks Prettier if you upgrade.