Skip to content

chore: use correct prettier version in ci #8321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 5, 2023
Merged

chore: use correct prettier version in ci #8321

Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c46e06f
chore: fmt ci uses correct node setup
Emyrk Jul 5, 2023
bd122b5
fixup! chore: fmt ci uses correct node setup
Emyrk Jul 5, 2023
d940111
try with installing all deps
Emyrk Jul 5, 2023
57e6aa9
CI stuck?
Emyrk Jul 5, 2023
5631cfe
Remove with block
Emyrk Jul 5, 2023
fefd1ed
Revert to only install prettier
Emyrk Jul 5, 2023
acbeb7b
Implement a cache key for the prettier only cache
Emyrk Jul 5, 2023
dcf6c3c
Optional skip yarn_install
Emyrk Jul 5, 2023
13347dc
Install prettier locally
Emyrk Jul 5, 2023
81eabcd
Install prettier to global
Emyrk Jul 5, 2023
3003d21
use a local prettier
Emyrk Jul 5, 2023
41646cf
install prettier in site directory
Emyrk Jul 5, 2023
40fda6d
Do not skip install
Emyrk Jul 5, 2023
44069aa
Skip installing all deps
Emyrk Jul 5, 2023
52b6cb9
use the yarn cache
Emyrk Jul 5, 2023
c2b923d
Do not reload cache at all
Emyrk Jul 5, 2023
c1a2b77
Revert action file
Emyrk Jul 5, 2023
74e5b50
fixup! Revert action file
Emyrk Jul 5, 2023
ceea463
Save prettier cache
Emyrk Jul 5, 2023
6b7398b
remove cache, just get it working
Emyrk Jul 5, 2023
21829d6
Install correct prettier globally
Emyrk Jul 5, 2023
e627c15
format ci file
Emyrk Jul 5, 2023
97931f4
only install prettier
Emyrk Jul 5, 2023
ed417d0
Add comments
Emyrk Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,16 @@ jobs:
go-version: 1.20.5

- name: Install prettier
run: npm install -g prettier
# We only need prettier for fmt, so do not install all dependencies.
# There is no way to install a single package with yarn, so we have to
# make a new package.json with only prettier listed as a dependency.
# Then running `yarn` will only install prettier.
run: |
cd site
mv package.json package.json.bak
jq '{dependencies: {prettier: .devDependencies.prettier}}' < package.json.bak > package.json
yarn --frozen-lockfile
mv package.json.bak package.json

- name: Install shfmt
run: go install mvdan.cc/sh/v3/cmd/shfmt@v3.5.0
Expand Down