feat: Add buildinfo package to embed version #840
Merged
+137
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #840 +/- ##
==========================================
- Coverage 66.06% 65.80% -0.27%
==========================================
Files 202 205 +3
Lines 13209 13309 +100
Branches 87 87
==========================================
+ Hits 8727 8758 +31
- Misses 3600 3655 +55
- Partials 882 896 +14
Continue to review full report at Codecov.
|
coadler
approved these changes
Apr 4, 2022
cli/buildinfo/buildinfo.go
Outdated
| if !valid { | ||
| return repo | ||
| } | ||
| return repo + "/commit/" + revision |
There was a problem hiding this comment.
path.Join might make this a bit cleaner!
This also resolves build time and commit hash using the Go 1.18 debug/buildinfo package. An external URL is outputted on running version as well to easily route the caller to a release or commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also resolves build time and commit hash using the
Go 1.18 debug/buildinfo package. An external URL is outputted
on running version as well to easily route the caller to a
release or commit.
Closes #493.