Skip to content

feat(site): add warning for unhealthy workspace #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2023
Merged

feat(site): add warning for unhealthy workspace #8422

merged 3 commits into from
Jul 12, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Added a warning in the workspace page:
Screen Shot 2023-07-11 at 10 07 25

Added a warning icon as we do when showing the outdated warning:
Screen Shot 2023-07-11 at 10 04 02

Close #8343

@BrunoQuaresma BrunoQuaresma requested review from mafredri and bpmct July 11, 2023 13:42
@BrunoQuaresma BrunoQuaresma self-assigned this Jul 11, 2023
@BrunoQuaresma BrunoQuaresma changed the title feat(site): make noticeable when a workspace is unhealthy feat(site): add warning for unhealthy workspace Jul 11, 2023
mafredri
mafredri approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a small rephrasing, but otherwise looks good. Should we expand the mock data in the stories to more closely resemble the response for unhealthy? (E.g. an uuid in failing agents and modify the resource to set the agent health too.)

@BrunoQuaresma BrunoQuaresma merged commit bff73ad into main Jul 12, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/unhealthy-warning branch July 12, 2023 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Improve UI for when one of the agents are unhealthy
2 participants
@BrunoQuaresma @mafredri