Skip to content

chore: group various npm dependencies #8453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Conversation

matifali
Copy link
Member

@matifali matifali commented Jul 12, 2023

This PR groups various npm dependencies for dependabot PRs.

  1. react
    • "react*"
    • "@types/react*"
  2. xterm:
    • "xterm*"
  3. xstate:
  4. mui:
  5. storybook:
  6. eslint:
    • "eslint*"
    • "@eslint*"
    • "@typescript-eslint/eslint-plugin"
    • "@typescript-eslint/parser"
  7. jest:
    • "jest*"
    • "@swc/jest"
    • "@types/jest"

@matifali
Copy link
Member Author

@BrunoQuaresma, you can change or remove the grouping as more suitable.

@BrunoQuaresma
Copy link
Collaborator

Not sure if I got it, what is the advantage of using this?

@matifali
Copy link
Member Author

@BrunoQuaresma This will create a single PR for the group instead of individual PRs for each dependency. Enabling this would be harmless, I guess, and we can always revert if we see it not suitable.
I need your input on grouping as I am unsure which dependencies are related and must be updated together.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it and see how it goes. Thank you for the help.

@matifali matifali merged commit 19f5835 into main Jul 12, 2023
@matifali matifali deleted the matifali/dependabot-npm-groups branch July 12, 2023 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants