chore(site): Add XState Inspector #869
Conversation
| @@ -14,6 +14,6 @@ cd "${PROJECT_ROOT}" | |||
| ( | |||
| trap 'kill 0' SIGINT | |||
| create_initial_user & | |||
| CODERV2_HOST=http://127.0.0.1:3000 yarn --cwd=./site dev & | |||
| CODERV2_HOST=http://127.0.0.1:3000 INSPECT_XSTATE=true yarn --cwd=./site dev & | |||
There was a problem hiding this comment.
@presleyp I think we should move this to the package.json since it seems like something we'd always want to be true when running development. I think CODERDV2_HOST is defined here since we might want to point to our own backend and be able to invoke it separately from yarn dev
There was a problem hiding this comment.
I was trying to avoid annoying backend people with the tab opening when they don't want it.
|
Ugh, something went wrong when I tried to merge master, I might just close this PR and redo it |
Just needs conflict resolution, I think a flag was removed something like Looks like yours should cleanly apply from the GitHub UI editor:
|
The issue is that I already fixed the conflict, but something must have gotten messed up as I merged because the usual merge commit message wasn't there, and then I see that it thinks the conflicts are still there and thinks I changed 117 files. Let me know what you think about when the inspector should open (I thought requiring an extra flag that is always used by the develop script was the best compromise) and I'll deal with it. |
I think just go locally and and squash down to 1 commit then I think what happened was that your merge ran into a conflict, and you committed without resolution. At least that's my best guess...not entirely sure. |
This installs the library for using the official inspector and attempts to set it up to open in a new tab only when you are both in development mode and have set the
INSPECT_XSTATEenv var. Without the second condition, it works, but something is broken about accessing the second env var from within the app.