feat: wrap ssh with coder key #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
==========================================
- Coverage 65.75% 65.70% -0.06%
==========================================
Files 216 215 -1
Lines 13834 13725 -109
Branches 103 103
==========================================
- Hits 9097 9018 -79
+ Misses 3807 3785 -22
+ Partials 930 922 -8
Continue to review full report at Codecov.
|
|
You'll have to pipe the SSH command to |
kylecarbs
requested changes
Apr 7, 2022
kylecarbs
approved these changes
Apr 7, 2022
deansheather
approved these changes
Apr 7, 2022
|
@deansheather top-tier review 🏹🏹🏹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
GIT_SSH_COMMANDenvironment variable tocoder gitssh --. The double dash allows git to pass the command flags and they be ignored by cobra.coder gitsshwill grab the user's private key fromcoderd, write it to a temp file, and runssh -i /tmp/my-coder-key.coder publickeycommand so users can upload this key to their git provider.