Skip to content

chore: reword some workspace actions stuff #9061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Aug 12, 2023

I know this doesn't reword everything. The TLDR of this proposal is:

  • We do not refer to workspaces as locked, we refer to them as inactive
  • We call it "inactivity deletion" which deletes workspaces n days after being marked as inactive (with threshold defined above).

Still a bit tricky to wrap your head around so one idea is to leverage the helper text to make it extremely clear

Frame 1 (1)

@bpmct bpmct requested a review from sreya August 12, 2023 00:36
@bpmct bpmct requested a review from kylecarbs August 12, 2023 00:41
@bpmct
Copy link
Member Author

bpmct commented Aug 12, 2023

@kylecarbs We're curious for your thoughts as well

@bpmct
Copy link
Member Author

bpmct commented Aug 12, 2023

@sreya linting is broken. Can you just merge into your branch instead?

@sreya sreya merged commit 9927a3e into jon/wsbump Aug 14, 2023
@sreya sreya deleted the bpmct/actions-copy branch August 14, 2023 19:04
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants