Skip to content

fix: separate dev shell and dev image nix deps #9189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2023
Merged

fix: separate dev shell and dev image nix deps #9189

merged 2 commits into from
Aug 18, 2023

Conversation

kylecarbs
Copy link
Member

No description provided.

@kylecarbs kylecarbs self-assigned this Aug 18, 2023
@kylecarbs kylecarbs enabled auto-merge (squash) August 18, 2023 15:52
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@kylecarbs kylecarbs disabled auto-merge August 18, 2023 15:54
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -153,6 +159,13 @@
experimental-features = nix-command flakes
''
)
# Allow people to change shells!
(
pkgs.writeTextDir "etc/shells" ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need slash?

Suggested change
pkgs.writeTextDir "etc/shells" ''
pkgs.writeTextDir "/etc/shells" ''

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it adds that automatically

@kylecarbs kylecarbs enabled auto-merge (squash) August 18, 2023 15:56
@kylecarbs kylecarbs merged commit 9725ec0 into main Aug 18, 2023
@kylecarbs kylecarbs deleted the separatedeps branch August 18, 2023 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants