Skip to content

fix: assign labels for issue templates #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2022
Merged

fix: assign labels for issue templates #919

merged 1 commit into from
Apr 7, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Apr 7, 2022

I noticed the "bug" and "documentation" issue templates were not properly assigning labels. However, feature works.

@bpmct bpmct added the bug 🐛 label Apr 7, 2022
@bpmct bpmct requested a review from jsjoeio April 7, 2022 20:56
@bpmct bpmct self-assigned this Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022 •
edited
Loading

Codecov Report

Merging #919 (17046f4) into main (75ef1f4) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
- Coverage   65.74%   65.59%   -0.16%     
==========================================
  Files         224      221       -3     
  Lines       13916    13732     -184     
  Branches      105      105              
==========================================
- Hits         9149     9007     -142     
+ Misses       3836     3812      -24     
+ Partials      931      913      -18
Flag Coverage Δ
unittest-go-macos-latest 52.93% <ø> (+0.23%) ⬆️
unittest-go-postgres- 65.54% <ø> (-0.02%) ⬇️
unittest-go-ubuntu-latest 55.41% <ø> (+0.07%) ⬆️
unittest-go-windows-2022 ?
unittest-js 58.25% <ø> (ø)
Impacted Files Coverage Δ
cli/configssh.go 50.00% <0.00%> (-8.04%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
cli/templateinit.go 56.36% <0.00%> (-3.64%) ⬇️
coderd/provisionerdaemons.go 60.03% <0.00%> (-2.53%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
provisionerd/provisionerd.go 79.73% <0.00%> (ø)
pty/start_windows.go
agent/usershell/usershell_windows.go
pty/pty_windows.go
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ef1f4...17046f4. Read the comment docs.

jsjoeio
jsjoeio approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 🔥

@bpmct bpmct enabled auto-merge (squash) April 7, 2022 21:03
@bpmct bpmct merged commit c6a0078 into main Apr 7, 2022
@bpmct bpmct deleted the bpmct/fix-issue-template-label branch April 7, 2022 21:04
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees

@bpmct bpmct

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@bpmct @jsjoeio @misskniss