-
Notifications
You must be signed in to change notification settings - Fork 937
feat: cli: add autostart and autostop commands #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #922 +/- ##
==========================================
+ Coverage 65.78% 65.82% +0.04%
==========================================
Files 226 228 +2
Lines 13991 14119 +128
Branches 105 105
==========================================
+ Hits 9204 9294 +90
- Misses 3848 3876 +28
- Partials 939 949 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great code, tests, and decomposition! 'tis coming together nicely.
Should we hide these commands for now? I know a bunch of the commands don't work properly right now, but I'd hate to add even more to that list (by work properly I mean that since we don't have scheduling in yet, this wouldn't quite work).
cli/workspaceautostart.go
Outdated
|
||
func workspaceAutostart() *cobra.Command { | ||
autostartCmd := &cobra.Command{ | ||
Use: "autostart", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a description of the autostart feature. Doesn't have to be exhaustive for now, just something that speaks to the use-case a bit.
cli/workspaceautostop.go
Outdated
|
||
func workspaceAutostop() *cobra.Command { | ||
autostopCmd := &cobra.Command{ | ||
Use: "autostop", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little helper text would be great here! Same comment on autostart
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is squeaky clean!
Ah yeah, good call. |
This PR adds the CLI commands
autostart
andautostop
.These allow enabling and disabling workspace autostart and autostop, respectively.
Example usage:
Subtasks