Skip to content

chore(site): rename userXService to authXService #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

presleyp
Copy link
Contributor

@presleyp presleyp commented Apr 8, 2022

Prep for #592 so the auth and users xServices don't get confused.

@presleyp presleyp requested a review from a team as a code owner April 8, 2022 14:59
@presleyp presleyp self-assigned this Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #924 (5980ef4) into main (94ab6f3) will decrease coverage by 0.05%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
- Coverage   65.75%   65.70%   -0.06%     
==========================================
  Files         226      226              
  Lines       13998    13998              
  Branches      105      105              
==========================================
- Hits         9204     9197       -7     
- Misses       3854     3858       +4     
- Partials      940      943       +3     
Flag Coverage Δ
unittest-go-macos-latest 53.06% <ø> (+0.12%) ⬆️
unittest-go-postgres- 65.61% <ø> (+0.11%) ⬆️
unittest-go-ubuntu-latest 55.36% <ø> (-0.10%) ⬇️
unittest-go-windows-2022 52.20% <ø> (-0.06%) ⬇️
unittest-js 58.25% <38.88%> (ø)
Impacted Files Coverage Δ
site/src/components/Navbar/index.tsx 0.00% <0.00%> (ø)
site/src/components/Page/RequireAuth.tsx 0.00% <0.00%> (ø)
site/src/pages/cli-auth.tsx 0.00% <0.00%> (ø)
site/src/xServices/auth/authXService.ts 81.81% <50.00%> (ø)
site/src/pages/login.tsx 90.47% <80.00%> (ø)
site/src/xServices/StateContext.tsx 100.00% <100.00%> (ø)
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
peer/conn.go 78.93% <0.00%> (-3.05%) ⬇️
coderd/provisionerdaemons.go 61.55% <0.00%> (-0.51%) ⬇️
provisionerd/provisionerd.go 80.02% <0.00%> (+0.29%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ab6f3...5980ef4. Read the comment docs.

@presleyp presleyp merged commit 0bf9dee into main Apr 8, 2022
@presleyp presleyp deleted the auth-xservice/presley branch April 8, 2022 15:42
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants