Skip to content

fix: Disable raw using confirm prompt on Darwin #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

kylecarbs
Copy link
Member

This caused cancel errors on prompt, but would have caused incorrect
content in parameter values if it surfaced.

Fixes #915.

This caused cancel errors on prompt, but would have caused incorrect
content in parameter values if it surfaced.

Fixes #915.
@kylecarbs kylecarbs requested a review from johnstcn April 8, 2022 15:36
@kylecarbs kylecarbs self-assigned this Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #926 (533898e) into main (38f0742) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
- Coverage   65.78%   65.57%   -0.22%     
==========================================
  Files         226      226              
  Lines       13991    13991              
  Branches      105      105              
==========================================
- Hits         9204     9174      -30     
- Misses       3848     3874      +26     
- Partials      939      943       +4     
Flag Coverage Δ
unittest-go-macos-latest 52.93% <0.00%> (-0.04%) ⬇️
unittest-go-postgres- 65.52% <0.00%> (-0.13%) ⬇️
unittest-go-ubuntu-latest 55.29% <0.00%> (+0.04%) ⬆️
unittest-go-windows-2022 52.15% <0.00%> (-0.01%) ⬇️
unittest-js 58.25% <ø> (ø)
Impacted Files Coverage Δ
cli/cliui/prompt.go 71.60% <0.00%> (ø)
codersdk/provisionerdaemons.go 58.46% <0.00%> (-6.16%) ⬇️
coderd/provisionerdaemons.go 59.02% <0.00%> (-3.55%) ⬇️
peer/conn.go 79.94% <0.00%> (-0.77%) ⬇️
peer/channel.go 83.04% <0.00%> (-0.59%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
provisionerd/provisionerd.go 80.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f0742...533898e. Read the comment docs.

@kylecarbs kylecarbs merged commit cb5b228 into main Apr 8, 2022
@kylecarbs kylecarbs deleted the fixcancel branch April 8, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: 'Error: canceled' message GCP Linux after pasting private key on 'coder templates create mark-first-project'
2 participants