Skip to content

fix: preferences routing and dropdown positioning #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 8, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner April 8, 2022 17:20
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #930 (396cc82) into main (53db178) will decrease coverage by 0.15%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
- Coverage   65.97%   65.81%   -0.16%     
==========================================
  Files         228      228              
  Lines       14126    14126              
  Branches      105      105              
==========================================
- Hits         9319     9297      -22     
- Misses       3863     3880      +17     
- Partials      944      949       +5     
Flag Coverage Δ
unittest-go-macos-latest 53.34% <ø> (+0.14%) ⬆️
unittest-go-postgres- 65.67% <ø> (-0.30%) ⬇️
unittest-go-ubuntu-latest 55.68% <ø> (+0.08%) ⬆️
unittest-go-windows-2022 52.52% <ø> (+0.03%) ⬆️
unittest-js 58.25% <50.00%> (ø)
Impacted Files Coverage Δ
site/src/AppRouter.tsx 0.00% <0.00%> (ø)
site/src/components/Navbar/UserDropdown.tsx 96.29% <100.00%> (ø)
codersdk/provisionerdaemons.go 58.46% <0.00%> (-6.16%) ⬇️
coderd/parameter/compute.go 74.07% <0.00%> (-4.45%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
coderd/provisionerdaemons.go 60.03% <0.00%> (-2.03%) ⬇️
peer/conn.go 78.68% <0.00%> (-1.53%) ⬇️
coderd/database/queries.sql.go 83.75% <0.00%> (-0.22%) ⬇️
peerbroker/proxy.go 58.13% <0.00%> (+0.58%) ⬆️
provisionerd/provisionerd.go 81.79% <0.00%> (+1.02%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53db178...396cc82. Read the comment docs.

@BrunoQuaresma BrunoQuaresma changed the title fix: preferences routing fix: preferences routing and dropdown positioning Apr 8, 2022
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) April 8, 2022 17:41
@BrunoQuaresma BrunoQuaresma merged commit b317f9a into main Apr 8, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-user-dropdown-nav branch April 8, 2022 18:58
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants