Skip to content

fix: Remove excessive margin on the right #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2022
Merged

fix: Remove excessive margin on the right #931

merged 1 commit into from
Apr 8, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

  • Removed unecessary marginRight

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner April 8, 2022 17:26
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 8, 2022
kylecarbs
kylecarbs approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the title a bit to be more specific, maybe: "fix: Remove excessive margin on the right". Seems fine to me though!

@codecov
Copy link

codecov bot commented Apr 8, 2022 •
edited
Loading

Codecov Report

Merging #931 (7e47a02) into main (53db178) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
+ Coverage   65.97%   66.00%   +0.03%     
==========================================
  Files         228      225       -3     
  Lines       14126    13942     -184     
  Branches      105      105              
==========================================
- Hits         9319     9202     -117     
+ Misses       3863     3817      -46     
+ Partials      944      923      -21
Flag Coverage Δ
unittest-go-macos-latest 53.13% <ø> (-0.07%) ⬇️
unittest-go-postgres- 66.12% <ø> (+0.15%) ⬆️
unittest-go-ubuntu-latest 55.67% <ø> (+0.07%) ⬆️
unittest-go-windows-2022 ?
unittest-js 58.25% <ø> (ø)
Impacted Files Coverage Δ
site/src/components/TabPanel/index.tsx 0.00% <ø> (ø)
cli/configssh.go 50.00% <0.00%> (-8.04%) ⬇️
codersdk/provisionerdaemons.go 58.46% <0.00%> (-6.16%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
cli/templateinit.go 56.36% <0.00%> (-3.64%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
peer/conn.go 78.93% <0.00%> (-1.27%) ⬇️
coderd/parameter/compute.go 78.51% <0.00%> (ø)
pty/start_windows.go
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53db178...7e47a02. Read the comment docs.

@code-asher code-asher linked an issue Apr 8, 2022 that may be closed by this pull request
Bug: Preferences in Firefox get pushed over to the right #925
Closed
code-asher
code-asher approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

@BrunoQuaresma BrunoQuaresma changed the title fix: fix layout fix: Remove excessive margin on the right Apr 8, 2022
@BrunoQuaresma
Copy link
Collaborator Author

Closes #925

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) April 8, 2022 17:40
@BrunoQuaresma BrunoQuaresma merged commit cbd1c3e into main Apr 8, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-preference-layout branch April 8, 2022 17:45
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@code-asher code-asher code-asher approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Bug: Preferences in Firefox get pushed over to the right
4 participants
@BrunoQuaresma @kylecarbs @code-asher @misskniss