Skip to content

fix: update autostart/autostop text #9650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: update autostart/autostop text #9650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/src/pages/WorkspacePage/BuildRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const BuildRow: React.FC<BuildRowProps> = ({ build }) => {
>
<span>
<strong>{initiatedBy}</strong>{" "}
{build.reason !== "initiator" ? "automatically" : ""}
{build.reason !== "initiator" ? "automatically " : ""}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if there is a better way to make this space more explicit lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh 🤷‍♀️ as long as it's tested (which it is now)

<strong>{transitionMessages[build.transition]}</strong> the
workspace
</span>
Expand Down
46 changes: 46 additions & 0 deletions site/src/testHelpers/entities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,50 @@ export const MockWorkspaceBuild: TypesGen.WorkspaceBuild = {
daily_cost: 20,
};

export const MockWorkspaceBuildAutostart: TypesGen.WorkspaceBuild = {
build_number: 1,
created_at: "2022-05-17T17:39:01.382927298Z",
id: "1",
initiator_id: MockUser.id,
initiator_name: MockUser.username,
job: MockProvisionerJob,
template_version_id: MockTemplateVersion.id,
template_version_name: MockTemplateVersion.name,
transition: "start",
updated_at: "2022-05-17T17:39:01.382927298Z",
workspace_name: "test-workspace",
workspace_owner_id: MockUser.id,
workspace_owner_name: MockUser.username,
workspace_id: "759f1d46-3174-453d-aa60-980a9c1442f3",
deadline: "2022-05-17T23:39:00.00Z",
reason: "autostart",
resources: [MockWorkspaceResource],
status: "running",
daily_cost: 20,
};

export const MockWorkspaceBuildAutostop: TypesGen.WorkspaceBuild = {
build_number: 1,
created_at: "2022-05-17T17:39:01.382927298Z",
id: "1",
initiator_id: MockUser.id,
initiator_name: MockUser.username,
job: MockProvisionerJob,
template_version_id: MockTemplateVersion.id,
template_version_name: MockTemplateVersion.name,
transition: "start",
updated_at: "2022-05-17T17:39:01.382927298Z",
workspace_name: "test-workspace",
workspace_owner_id: MockUser.id,
workspace_owner_name: MockUser.username,
workspace_id: "759f1d46-3174-453d-aa60-980a9c1442f3",
deadline: "2022-05-17T23:39:00.00Z",
reason: "autostop",
resources: [MockWorkspaceResource],
status: "running",
daily_cost: 20,
};

export const MockFailedWorkspaceBuild = (
transition: TypesGen.WorkspaceTransition = "start",
): TypesGen.WorkspaceBuild => ({
Expand Down Expand Up @@ -843,6 +887,8 @@ export const MockWorkspaceBuildDelete: TypesGen.WorkspaceBuild = {

export const MockBuilds = [
MockWorkspaceBuild,
MockWorkspaceBuildAutostart,
MockWorkspaceBuildAutostop,
MockWorkspaceBuildStop,
MockWorkspaceBuildDelete,
];
Expand Down