Skip to content

ci: remove example templates readme from docs filter #9720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

matifali
Copy link
Member

This will run make gen on templates readme and avoid situations like #9715 where make gen was not run on the PR checks

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@matifali matifali enabled auto-merge (squash) September 18, 2023 10:33
@matifali
Copy link
Member Author

matifali commented Sep 18, 2023

It will also avoid skipping the deploy and build-main-image steps when templates are changed and will include the updated template in the new package.

@matifali matifali merged commit e6865e0 into main Sep 18, 2023
@matifali matifali deleted the examples-readme branch September 18, 2023 10:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants