Skip to content

fix: make sure fly_app name is lower case #9771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: make sure fly_app name is lower case #9771

merged 1 commit into from
Sep 19, 2023

Conversation

pi3ch
Copy link
Contributor

@pi3ch pi3ch commented Sep 19, 2023

fly_app does not support uppercase. Coder allows uppercase for username/owner.

@pi3ch
coder#9767 added lower() to owner
19026fa 
fly_app does not support uppercase. Coder allows uppercase for username/owner.
@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pi3ch
Copy link
Contributor Author

pi3ch commented Sep 19, 2023 •
edited
Loading

I have read the CLA Document and I hereby sign the CLA

@pi3ch pi3ch changed the title #9767 added lower() to owner #9767 added lower function to owner Sep 19, 2023
@pi3ch
Copy link
Contributor Author

pi3ch commented Sep 19, 2023

I have read the CLA Document and I hereby sign the CLA

@pi3ch
Copy link
Contributor Author

pi3ch commented Sep 19, 2023

recheck

cdrcommunity added a commit to coder/cla that referenced this pull request Sep 19, 2023
@cdrcommunity
@pi3ch has signed the CLA in coder/coder#9771
c736e39
@matifali matifali changed the title #9767 added lower function to owner fix: make sure fly_app name is lower case Sep 19, 2023
matifali
matifali approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@matifali matifali enabled auto-merge (squash) September 19, 2023 12:28
@matifali matifali disabled auto-merge September 19, 2023 12:29
@matifali matifali enabled auto-merge (squash) September 19, 2023 12:29
@matifali matifali merged commit 94cccd0 into coder:main Sep 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
@matifali matifali linked an issue Sep 19, 2023 that may be closed by this pull request
Uppecase username fails in default template workspace creation #9767
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

Assignees

@pi3ch pi3ch

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uppecase username fails in default template workspace creation
2 participants
@pi3ch @matifali