Skip to content

chore(site): rename deletion cue components #9876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

Kira-Pilot
Copy link
Member

Just a simple rename. I noticed we changed verbiage while I was out and thought we should be consistent.

Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@@ -265,7 +265,7 @@ export const Workspace: FC<React.PropsWithChildren<WorkspaceProps>> = ({
/>
</Cond>
<Cond>
{/* <ImpendingDeletionBanner/> determines its own visibility */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the classic "comment doesn't get updated even though it was right next to the code 😂

@Kira-Pilot Kira-Pilot merged commit 75366ec into main Sep 26, 2023
@Kira-Pilot Kira-Pilot deleted the banner-rename/kira-pilot branch September 26, 2023 18:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants