Skip to content

chore: include organization id in workspace build audit log #9905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Sep 28, 2023

Closes #9791

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming, we do not want to audit dry runs?

Audit: *auditor,
Log: s.Logger,
UserID: job.InitiatorID,
OrganizationID: workspace.OrganizationID,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's the trick 👍 I assumed that OrganizationID should be passed together with UserID, but didn't think about pulling it out from workspace.

@Emyrk
Copy link
Member Author

Emyrk commented Sep 28, 2023

just confirming, we do not want to audit dry runs?

Maybe we do, but that would be handled in the other switch case.

@Emyrk Emyrk merged commit 9e84521 into main Sep 28, 2023
@Emyrk Emyrk deleted the stevenmasley/workspace_build_org_audit branch September 28, 2023 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit logs: OrganizationID is missing
2 participants